Fix for potential file system corruption when truncating or overwriting file data with fault tolerant mode enabled#78
Open
jblanchard-jblopen wants to merge 1 commit intoeclipse-threadx:devfrom
Conversation
…g a new cluster deletion session in some corner cases where the end of the chain is reached.
rahmanih
reviewed
Dec 8, 2025
Contributor
rahmanih
left a comment
rahmanih
left a comment
There was a problem hiding this comment.
Hi @jblanchard-jblopen
Would it possible to have a more descriptive commit message?
rahmanih
reviewed
Dec 8, 2025
Contributor
rahmanih
left a comment
rahmanih
left a comment
There was a problem hiding this comment.
can we respect the coding style?
if (condition)
{
}
fdesbiens
changed the title
Contributor
|
@jblanchard-jblopen, can you fix the bracket style per @rahmanih's feedback, please? I will merge this right after this change is made. |
Author
|
I should have it done during the day today.
Kind regards,
Jonathan
…On Thu, Feb 5, 2026 at 3:39 PM Frédéric Desbiens ***@***.***> wrote:
*fdesbiens* left a comment (eclipse-threadx/filex#78)
<#78 (comment)>
@jblanchard-jblopen <https://github.com/jblanchard-jblopen>, can you fix
the bracket style per @rahmanih <https://github.com/rahmanih>'s feedback,
please? I will merge this right after this change is made.
—
Reply to this email directly, view it on GitHub
<#78 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARXNZXLTUGL4EAYSX2UWX4L4KOTBRAVCNFSM6AAAAACMBHJ5CGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQNJWGA3DSNJRGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tentative fix for issue #77. Check if the end of the chain was reached before setup up the next session.